Skip to content

Conversation

rapaelector
Copy link

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

@oleibman
Copy link
Collaborator

Aside from fixing errors, this PR needs a much better description. Please edit it to provide one.

@rapaelector
Copy link
Author

Still working on it sorry for that

@raziel057
Copy link

I was also working on it on a branch based on the PR for read part (#4664).
I still have to fix phpstan, check under real conditions and add tests: raziel057@4ccf9c0

@raziel057
Copy link

You can close this PR in favor of this one #4677 as it's working. I propose you to have a look and test it on your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants